HomeeNTiDi

Fix T118: simplify table cell destruction

Authored by ntd on Apr 27 2020, 9:51 PM.

Description

Fix T118: simplify table cell destruction

When removing a cell from the hash table of AdgTable, use
g_hash_table_foreach_remove(). This is simpler and more robust (handles
multiple instances of the same cell gracefully).

The old code was conceptually right, but removing a cell without name
resulted in a call to g_hash_table_remove() with a NULL key (hence the
crash reported in the issue).

Details

Committed
ntdApr 27 2020, 9:51 PM
Parents
rADG8846c7588209: adg: refactor for easier maintenance
Branches
Unknown
Tags
Unknown
Tasks
T118: adg_table_cell_new_full() crash on duplicate names